[tor-bugs] #24367 [Core Tor/Tor]: Changing pluggable transports (during start-up) in Tor Browser is broken

[Tor Bug Tracker & Wiki]

#24367: Changing pluggable transports (during start-up) in Tor Browser is broken
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  030-backport, 031-backport,          |  Actual Points:
  regression, tor-bridge-client, s8-errors,      |
  tbb-wants                                      |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 > 1. Why did we pick LeifEricson for our connection the second time, after
 we had chosen 3 other primary guards?

 So, what should have happened here is that we should have tried to fetch
 our primary guards' descriptors before building circuits, and not fallen
 back to this entry far down later in the guard set.  The logic that's
 supposed to stop that is in
 guard_selection_get_err_str_if_dir_info_missing().  But also, I don't see
 us launching requests for any of the new primary guards! Something's going
 wrong there.

 > 2.  So we're looking up the wrong transport entirely.

 I think this is an artifact of looking at `conn->addr` instead of
 `conn->real_addr`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24367#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online