[tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  igt0
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,       |  Actual Points:
  TorBrowserTeam201712                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the feedback! I updated the patch.

 https://trac.torproject.org/projects/tor/attachment/ticket/22084/0001
 -PATCH-Bug-1372072-Part-1-Spoofing-network-informatio.2.patch

 https://trac.torproject.org/projects/tor/attachment/ticket/22084/0002
 -PATCH-Bug-1372072-Part-2-Add-a-test-case-for-check-w.2.patch

 Replying to [comment:13 gk]:
 > We are close! Could you just remove two superfluous newlines? One at:
 > {{{
 >  #include "nsINetworkProperties.h"
 > +#include "nsContentUtils.h"
 > +
 > }}}
 > and the other one, which is `git` complaining about, at the end of the
 test file:
 > {{{
 > +  await testWindow();
 > +});
 > +
 > }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22084#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online