[tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
----------------------------------+--------------------------
 Reporter:  isis                  |          Owner:  isis
     Type:  defect                |         Status:  closed
 Priority:  High                  |      Milestone:
Component:  Obfuscation/BridgeDB  |        Version:
 Severity:  Normal                |     Resolution:  fixed
 Keywords:  bridgedb-dist moat    |  Actual Points:  1
Parent ID:                        |         Points:  1
 Reviewer:                        |        Sponsor:  SponsorM
----------------------------------+--------------------------
Changes (by isis):

 * status:  needs_review => closed
 * resolution:   => fixed
 * actualpoints:  .5 => 1


Comment:

 Replying to [comment:8 isis]:
 > Replying to [comment:6 mcs]:
 > > * For the `/fetch` request, the `type` is specified as `moat-
 transports` but the implementation uses `client-transports`. For
 consistency with the other `type` values you may want to use `moat-
 transports`.
 >
 >
 [https://gitweb.torproject.org/user/isis/bridgedb.git/commit/?h=develop&id=50a9321fadcfd0e9a4f30bc1919c1bf46d27d8e1
 50a9321f]

 Oops, I believe the original behaviour was actually correct: the client,
 when requesting /fetch, sends a `"type": "client-transports"`. The server,
 when responding to that request, iff there was no overlap in which
 transports are supported, sends `"type": "moat-transports"` to let the
 client software know which types it ''does'' have available.

 I've reverted 50a9321f.

 Closing as fixed; fingers crossed nothing else is broken.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24433#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online