[tor-bugs] #24580 [Metrics/ExoneraTor]: Let ExoneraTor only serve completed dates

[Tor Bug Tracker & Wiki]

#24580: Let ExoneraTor only serve completed dates
--------------------------------+--------------------------------
 Reporter:  karsten             |          Owner:  iwakeh
     Type:  enhancement         |         Status:  needs_revision
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  iwakeh              |        Sponsor:
--------------------------------+--------------------------------
Changes (by iwakeh):

 * status:  accepted => needs_revision


Comment:

 Please review four commits on
 [https://gitweb.torproject.org/user/iwakeh/exonerator.git/log/?h=task-24580
 this branch].

 I tried to encapsulate all date related requests in a special
 ExoneraTorDate class and also separated the tests and extended them a
 little.  The goal is to make the servlets decision making obvious from the
 code and have the decision making about the date parameter in one place.
 Please check that the existing logic didn't get changed in the process.
 (Maybe, the tests could be altered to catch the things that you find?)

 The final commit tweaks the error message a little to tell users when to
 return.

 (The very same approach of encapsulation could also be used for the ip
 parameter later.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24580#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online