[tor-bugs] #24011 [Core Tor/Tor]: Attempt to open a stream on first hop of circuit

[Tor Bug Tracker & Wiki]

#24011: Attempt to open a stream on first hop of circuit
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.2.2-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  tor-circuit   |  Actual Points:
Parent ID:                |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Ok I bet everything that this is why we see this warning now:
 66aff2d8f35217cc802bd46eeeaf49326d7de4b0

 Originally, we were using `is_first_hop` instead of "is client" and here
 is how it was set:

 {{{
   circ->is_first_hop = (created_cell->cell_type == CELL_CREATED_FAST);
 }}}

 Leaving behind the `CREATE` and `CREATE2` that also makes a channel being
 marked as a client. This was modified after we removed
 `AllowSingleHopExits` with commit: d52a1e2faaf

 So now the question is still how did the channel on the OR connection got
 flagged as a client?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24011#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online