[tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

[Tor Bug Tracker & Wiki]

#24423: Fix STACK warnings in Tor
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-27  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  catalyst         |        Sponsor:
-----------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 The code changes look good to me!  Possible minor documentation
 improvements below.  Feel free to merge without another round of review
 after any doc changes.

 Spelling ("happend") in changes file.

 In d8f0417799f8eaa0865cd8ba24e04f7689c99d78 maybe clarify in the commit
 message what the STACK warning is about?  (Is it a potential signed
 underflow?)

 In 8922986c3190bc3cb0b9036d7e024817c307bd6a "swapping over into unsigned
 integers" seems like it's mostly an issue for 32-bit platforms; should
 that be mentioned in the commit message?

 In 370916f75e2f00ea4b6f0f1f1ccf3df04504aab7 maybe clarify in the commit
 message that `new_element()` can't return `NULL` because
 `tor_malloc_zero()` can't return `NULL`?  Similarly for
 4b2f8c35f69744632e14684e76dc5484202dc7ae.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online