[tor-bugs] #23966 [Core Tor/Tor]: Refactor node_has_curve25519_onion_key() to use node_get_curve25519_onion_key()

Mon Dec 11 07:43:13 UTC 2017

#23966: Refactor node_has_curve25519_onion_key() to use
node_get_curve25519_onion_key()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  defect          |         Status:  new
 Priority:  Medium          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  easy, refactor  |  Actual Points:
Parent ID:                  |         Points:  0.2
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by aruna1234):

 So, have thought of something:

 All the calls to node_has.. will be replaced by node_get.. .Instead we
 will call node_get..() and check if the value that is returned is NULL or
 not. If it is not NULL then we'll call
 routerinfo_has_curve25519_onion_key() in routerlist.c, otherwise its zero.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23966#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online