[tor-bugs] #24367 [Core Tor/Tor]: Changing pluggable transports (during start-up) in Tor Browser is broken

[Tor Bug Tracker & Wiki]

#24367: Changing pluggable transports (during start-up) in Tor Browser is broken
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, tor-bridge-client,       |  Actual Points:
  s8-errors, tbb-wants                           |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by teor):

 It is likely that this change in #24392 fixes at least part of this issue,
 but that ticket still needs revision:
 {{{
      case DL_SCHED_BRIDGE:
        /* A bridge client downloading bridge descriptors */
 -      if (options->UseBridges && any_bridge_descriptors_known()) {
 +      if (options->UseBridges && num_bridges_usable() > 0) {
          /* A bridge client with one or more running bridges */
          return options->TestingBridgeDownloadSchedule;
        } else {
          /* A bridge client with no running bridges */
          return options->TestingBridgeBootstrapDownloadSchedule;
        }
 }}}

 Before the change, we would check for cached bridge descriptors, which is
 definitely wrong. After the change, we check for running bridges, which is
 the right thing to do. (But it might still need a fix or two to work.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24367#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online