[tor-bugs] #24337 [Core Tor/Tor]: Every _free() function should be a macro that sets the corresponding pointer to NULL.

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 8 14:29:26 UTC 2017


#24337: Every _free() function should be a macro that sets the corresponding
pointer to NULL.
----------------------------------------------+----------------------------
 Reporter:  nickm                             |          Owner:  nickm
     Type:  enhancement                       |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.3.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  review-group-26, review-group-27  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  dgoulet                           |        Sponsor:
                                              |  Sponsor8-can
----------------------------------------------+----------------------------

Comment (by nickm):

 I did the line-splitting by hand.  I'm not super excited to go through and
 reindent all the lines -- though I'd run a script to do it, if we can have
 one that isn't super-disruptive.

 I'd like to apply this to static free function as well, but that will take
 a little longer. Shall I give it a try?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24337#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list