[tor-bugs] #23966 [Core Tor/Tor]: Refactor node_has_curve25519_onion_key() to use node_get_curve25519_onion_key()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Dec 7 02:37:46 UTC 2017
#23966: Refactor node_has_curve25519_onion_key() to use
node_get_curve25519_onion_key()
----------------------------+------------------------------------
Reporter: teor | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy, refactor | Actual Points:
Parent ID: | Points: 0.2
Reviewer: | Sponsor:
----------------------------+------------------------------------
Comment (by aruna1234):
Replying to [comment:3 teor]:
> Replying to [comment:2 aruna1234]:
> > could you give more information?
>
> These functions have code that's almost identical.
> We can implement node_has… by calling node_get… and checking the result.
> The result is valid if it passes the existing check in node_has….
>
> This might be a good ticket for you to focus on, because it is a small
first-time change for you to learn C and learn our processes.
Does that mean that we can replace all calls to function node_has... by
calling node_get... without any ambiguity i.e if it passes all tests.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23966#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list