[tor-bugs] #24486 [Core Tor/Tor]: Mark all bridges as up on application activity

[Tor Bug Tracker & Wiki]

#24486: Mark all bridges as up on application activity
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, tor-bridge-client,       |  Actual Points:
  s8-errors                                      |
Parent ID:  #24367                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Oh, ok, so arma is half-right here. We need to count the number of
 configured bridges in this code, because the other choices don't do what
 we want:
 * using any_bridge_descriptors_known() is wrong because it counts cached
 bridges, and we might not have any cached descriptors, or we might have
 some of the wrong type
 * using num_bridges_usable() > 0 is wrong because it counts usable
 bridges, and we might not have any marked as usable

 Now I understand this issue, I'm going to review all my changes in #24392
 to make sure I chose the right function out of these three different
 functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24486#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online