[tor-bugs] #23271 [Core Tor/Tor]: control_auth_cookie isn't deleted when tor stops

[Tor Bug Tracker & Wiki]

#23271: control_auth_cookie isn't deleted when tor stops
------------------------------+------------------------------------
 Reporter:  yurivict271       |          Owner:  (none)
     Type:  defect            |         Status:  needs_revision
 Priority:  Medium            |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor      |        Version:  Tor: 0.3.0.10
 Severity:  Normal            |     Resolution:
 Keywords:  easy tor-control  |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.3.3.x-final


Comment:

 Replying to [comment:10 ffmancera]:
 > Done, I hope everything is fine!
 >
 > Note: Consider the second patch.

 Thanks for the patch! You are very close!

 A few things:
 - Instead of providing a patch file, it's better to publish your work on a
 git branch somewhere (e.g. on github) and link us to your repository. It's
 easier for us this way.
 - The changes file could be improved. It's user-facing so words like
 `unlink` and `tor_cleanup()` are not so helpful. Instead saying `Tor now
 deletes the CookieAuthFile when it stops` might be better. Also we say
 `Closes ticket 23271` instead of `Closes 23271`. You can run `make check-
 changes` to get warnings for these sort of stuff.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23271#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online