[tor-bugs] #23603 [Core Tor/Tor]: hs: Cleanup race between circuit close and free with the HS circuitmap

[Tor Bug Tracker & Wiki]

#23603: hs: Cleanup race between circuit close and free with the HS circuitmap
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Ok I took over. I had to do some moving and put the function in
 `hs_circuit.c` as well, thought it would be more accurate there.

 Branch: `bug23603_032_02`

 Notice couple of things. First, that cleanup needs to be done on both or
 and origin circuit. Second, w need to do it before the hs_ident is freed
 because the `has_closed()` needs it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23603#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online