[tor-bugs] #23114 [Core Tor/Tor]: Circuit Build Timeout should apply at circuit completion

[Tor Bug Tracker & Wiki]

#23114: Circuit Build Timeout should apply at circuit completion
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  guard-discovery-prop247-controller,  |  Actual Points:
  review-group-25, review-group-26               |
Parent ID:  #23100                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Okay, I've read the code here, and read over the history.  I think it
 makes sense at this point to put comments on the squashed branch instead.

 To capture my comments on the branch, I have made new fixup commits for
 the issues where I thought it was easier to just "code what I meant" --
 please review those commits and let me know if you think any are wrong?
 They are mostly cosmetic and documentation issues, except for one that
 fixes a bug in the denominator of close_rate.

 I've made a new oniongit merge request --
 https://oniongit.eu/network/tor/merge_requests/8 is where I am writing
 comments.

 Mike, please let me know what you think about the comments and the new
 fixup commits there?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23114#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online