[tor-bugs] #24509 [Core Tor/Tor]: circuit_can_use_tap() should only allow TAP for v2 onion services

[Tor Bug Tracker & Wiki]

#24509: circuit_can_use_tap() should only allow TAP for v2 onion services
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, security-low,       |  Actual Points:
  easy, intro                                    |
Parent ID:                                       |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Ah, undocumented state machines, aren't they fun?

 I'd suggest you look for the code that changes circuit purposes to the
 ones we're looking for, Hopefully these functions come on v2 and v3
 varieties, or they otherwise have some context that lets us know which
 version we're using.

 When you find those call sites, if there is no existing struct member that
 gives us the version information, add a 1-bit flag to the circuit struct
 that tells us whether it's v2 or v3.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24509#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online