[tor-bugs] #23603 [Core Tor/Tor]: hs: Cleanup race between circuit close and free with the HS circuitmap

[Tor Bug Tracker & Wiki]

#23603: hs: Cleanup race between circuit close and free with the HS circuitmap
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  accepted => needs_review
 * reviewer:   => asn


Comment:

 I've taken the old patch and asn's test. Rebased it on latest 032.

 This fixes two things that this ticket found as issues. They are in two
 separate commits. Third commit adds asn's test.

 The issue with `circuit_retries` is *not* addressed in here but it is also
 not critical, the service will still work and it should be a rare case.
 But, we should definitely fix it. I propose its own ticket once this is
 merged and we agree.

 Branch: `bug23603_032_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23603#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online