[tor-bugs] #22990 [Metrics/Library]: Add a heartbeat log message indicating progress and estimated time left

[Tor Bug Tracker & Wiki]

#22990: Add a heartbeat log message indicating progress and estimated time left
-----------------------------+--------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2017     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+--------------------------------
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 I'd like to use a Logger different from the standard Logger.  Maybe,
 'statistics' as in Onionoo, i.e.,
 `LoggerFactory.getLogger("statistics")...`?  The progress information is
 rather of statistical nature,  the log statements will show up in the
 general ('-all.log') anyway; and it would be possible to have the
 information separated by simple logback configuration.

 The percent calculation should only be done once: `100 * progress /
 total`.
 Why not only keep track of the percentage done, i.e., previousPercentDone
 and percentDone or similar?

 More importantly, `readTarballs` needs to catch the IOE to avoid halting
 the process just b/c of one tarball being faulty.

 Information about skipped tarballs should also be logged to the
 'statistics' logger and the tarball skipped should be logged as warning as
 before.

 Maybe, think about other possible statistics, which could be easily
 logged?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22990#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online