[tor-bugs] #24392 [Core Tor/Tor]: Ignore cached bridge descriptors until we check if they are running

[Tor Bug Tracker & Wiki]

#24392: Ignore cached bridge descriptors until we check if they are running
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, tor-bridge-client,       |  Actual Points:  0.3
  s8-errors                                      |
Parent ID:  #24367                               |         Points:  0.3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 I'm stuck in a maze of twisty little tickets, all being parents of each
 other, but: in proposed commit 690f646bf:

 {{{
 diff --git a/src/or/circuituse.c b/src/or/circuituse.c
 index aa0df95..8c9859b 100644
 --- a/src/or/circuituse.c
 +++ b/src/or/circuituse.c
 @@ -2084,7 +2084,7 @@ circuit_get_open_circ_or_launch(entry_connection_t
 *conn,
                 "used client functionality lately" :
                 "received a consensus with exits",
                 options->UseBridges ? "bridges" : "entrynodes");
 -      } else if (!options->UseBridges || any_bridge_descriptors_known())
 {
 +      } else if (!options->UseBridges || num_bridges_usable() > 0) {
          log_fn(severity, LD_APP|LD_DIR,
                 "Application request when we haven't %s. "
                 "Optimistically trying directory fetches again.",
 }}}

 teor, did you check that you didn't break this functionality? We have
 broken it several times in the past and taken years to notice.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24392#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online