[tor-bugs] #21998 [Applications/Tor Browser]: Add the option for debug builds to rbm

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 1 09:29:37 UTC 2017


#21998: Add the option for debug builds to rbm
-------------------------------------------+-------------------------------
 Reporter:  gk                             |          Owner:  tbb-team
     Type:  enhancement                    |         Status:
                                           |  needs_revision
 Priority:  Very High                      |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201712  |  Actual Points:
Parent ID:  #17379                         |         Points:
 Reviewer:                                 |        Sponsor:  Sponsor4
-------------------------------------------+-------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201711 => tbb-rbm, TorBrowserTeam201712


Comment:

 Thanks. One final thing. I am a bit wary to start collecting Firefox
 patches in `tor-browser-build`. While I think there could be an argument
 made for the #23231 workaround (who really is using plain tor-browser.git
 to cross-compile stuff for Windows??) I think it does not hold for the
 ASan case. We are shipping a `.mozconfig-asan` file and, in fact, if one
 uses Linux and wants to do dev work there is no need to use an `rbm` build
 for that. Thus, let's keep the workaround for #21925 in tor-browser.git.
 There should not be any breakage for the non-ASan series regardless the
 platform we compile for. And it would make the `tor-browser-build` patch
 simpler.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21998#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list