[tor-bugs] #21394 [Core Tor/Tor]: connection timeouts are affecting Tor Browser usability

[Tor Bug Tracker & Wiki]

#21394: connection timeouts are affecting Tor Browser usability
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  reopened
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-backport 030-backport            |  Actual Points:
  031-backport tbb-performance, tbb-usability,   |
  performance, tbb-needs                         |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:76 Dhalgren]:
 > A correct patch will be only slightly larger than the existing patch.
 Adding tuneable parameters is trivial, requires one line for each in or.h
 and in config.c, and one expression to obtain the value.

 The bugfix patch in this ticket has been backported and merged, so any new
 patch has to be built on top of it.

 We try to avoid tuneable parameters, because we have to test each option
 that we put in a torrc. Also, tuneable parameters are a new feature, so
 they won't get backported.

 > The current patch discards successful DNS replies that arrive between 5
 and 15 seconds and while the percentage of queries affected is small, the
 behavior is incorrect.  If an operator configures a single `named`
 resolver, no retries whatsoever are attempted.  0.2.9 will be around for
 two more years and a minor incremental effort towards correctness seems in
 order.

 Ok, thank you for describing the issue.

 Please submit any bugfix patches based on maint-0.2.9, and we'll test it
 in master, then consider backporting them.

 Please submit any feature patches that add new options based on master.

 And please use separate tickets for feature and bugfix patches. Otherwise,
 people are more likely to get confused, and they won't see all of your
 work.

 > My experience with open source is core developers generally feel
 compelled to change everything contributed to "make it theirs," without
 involving the contributor; has left me nonplussed.

 I'm sorry that this happened.
 I know I do it myself sometimes, but I try not to.

 I don't know exactly what happened in this case, and it's hard to tell by
 reading the ticket history. Please also understand that sometimes we
 change things so they are more maintainable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21394#comment:77>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online