[tor-bugs] #23357 [Core Tor/Tor]: Build with non-Cross-DSO CFI

[Tor Bug Tracker & Wiki]

#23357: Build with non-Cross-DSO CFI
----------------------------------------+----------------------------------
 Reporter:  shawn.webb                  |          Owner:  (none)
     Type:  enhancement                 |         Status:  needs_revision
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.2.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  security, defence-in-depth  |  Actual Points:
Parent ID:                              |         Points:  1.0
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------

Comment (by teor):

 Replying to [comment:2 shawn.webb]:
 > CFLAGS isn't set by that point, so autoconf will complain with an error
 that `+=` was used instead of `=`.

 Is CFLAGS ever set after this?
 Because if it is, it will overwrite the CFLAGS you just set.

 Replying to [comment:11 shawn.webb]:
 > So, what I can do, is expand the patch to apply the CFLAGS and LDFLAGS
 to more of the applications (rather than just tor). This way, we skip
 applying CFI to the library code (even though the libraries in the
 codebase get statically linked).

 Please make this change and re-submit a patch or git branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23357#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online