[tor-bugs] #14201 [Metrics/Onionoo]: Configure out/ directory path somewhere else than in web.xml.

[Tor Bug Tracker & Wiki]

#14201: Configure out/ directory path somewhere else than in web.xml.
-----------------------------+-------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  enhancement      |         Status:  merge_ready
 Priority:  Medium           |      Milestone:  Onionoo-1.4.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-------------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:10 karsten]:
 > Please review
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-14201
 my task-14201] branch.

 This looks fine.  The old approach was too eager and limiting this to the
 web component is better.

 One tiny thing in 'Main':
 {{{
 -  private Main() {/* empty */}
 +  private Main() {
 +  }
 }}}

 The
 [https://trac.torproject.org/projects/tor/wiki/org/teams/MetricsTeam/MetricsJavaStyleGuide#s4.1.3
 -braces-empty-blocks coding guidelines] state that empty blocks may be
 concise. I would prefer the comment or `{}` without comment to the
 dangling brace, which looks as if something was missing.

 Other than this, merge ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14201#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online