[tor-bugs] #23318 [Core Tor/Tor]: compute_weighted_bandwidths: do not add 0.5 to final_weight

[Tor Bug Tracker & Wiki]

#23318: compute_weighted_bandwidths: do not add 0.5 to final_weight
----------------------------+------------------------------------
 Reporter:  cypherpunks     |          Owner:  (none)
     Type:  defect          |         Status:  new
 Priority:  Very High       |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  path-selection  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by cypherpunks):

 It's not only case when code bypassing limits, as noticed by pastly in
 IRC. Guard nodes weights only if new guard added by
 `entry_guards_expand_sample`. Sample guard or subsets never being re-
 weighted: once sampled non-Exit Guard will be used as Exit+Guard (if
 operator change it policy) by client.
 (See related #22779)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23318#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online