[tor-bugs] #23343 [Core Tor/Tor]: prop224: Bug: Non-fatal assertion !((strlen(req_key_str) + REND_DESC_ID_V2_LEN_BASE32) < strlen(key)) failed

[Tor Bug Tracker & Wiki]

#23343: prop224: Bug: Non-fatal assertion !((strlen(req_key_str) +
REND_DESC_ID_V2_LEN_BASE32) < strlen(key)) failed
-----------------------------+------------------------------------
 Reporter:  asn              |          Owner:  (none)
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  prop224, tor-hs  |  Actual Points:
Parent ID:                   |         Points:  0.2
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 The comment before the condition is wrong I believe.

 The `key` is composed of both the HSDir base32 identity digest and either
 the base64 blinded key (v3) *OR* the base32 descriptor ID (v2) which is
 thus the different size explanation.

 But yeah BUG() was not a good idea! :P

 Apart from that, lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23343#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online