[tor-bugs] #23346 [Core Tor/Tor]: prop224: HSdir set changed detection fails sometimes

[Tor Bug Tracker & Wiki]

#23346: prop224: HSdir set changed detection fails sometimes
------------------------------+--------------------------------
     Reporter:  asn           |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  prop224, tor-hs
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:  SponsorR-can  |
------------------------------+--------------------------------
 Seems like our logic for detecting HSDir hash ring changes on the service-
 side is not 100% correct. That's function `service_desc_hsdirs_changed()`
 and family.

 David noticed that function thinking that the hsdir set changed when it
 actually didn't. That also happened right after a desc upload, which
 caused tor to order another upload instantly. Tor ended up doing two desc
 uploads in two seconds, which raced to the HSDirs and arrived there on the
 wrong order causing rev counter fails.

 We don't know the culprit yet but David added some debug logs that should
 help us out here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23346>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online