[tor-bugs] #23331 [Core Tor/Tor]: prop224: Don't build HS desc if we don't have a live consensus

[Tor Bug Tracker & Wiki]

#23331: prop224: Don't build HS desc if we don't have a live consensus
------------------------------+--------------------------------
     Reporter:  asn           |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  prop224
Actual Points:                |  Parent ID:
       Points:  0.1           |   Reviewer:
      Sponsor:  SponsorR-can  |
------------------------------+--------------------------------
 We currently block descriptor uploading until we have a live consensus,
 but we actually happily build the descriptor before that.

 That can cause various synch issues. One example is that if we build the
 descriptor without a live consensus, we will calculate a false timing
 period length because of `get_voting_interval()`.

 We should restrict any descriptor-related operations until we have a live
 consensus. After all, without a live consensus we can't upload the
 descriptor anyway, so no point in building before that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23331>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online