[tor-bugs] #22976 [Core Tor/Tor]: disallow tor exec'ing

[Tor Bug Tracker & Wiki]

#22976: disallow tor exec'ing
--------------------------------------+------------------------------------
 Reporter:  dawuud                    |          Owner:  nickm
     Type:  defect                    |         Status:  merge_ready
 Priority:  Medium                    |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  sandbox, review-group-22  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------------

Comment (by nickm):

 Replying to [comment:10 dgoulet]:
 > >  This isn't fundamentally about seccomp; it's about disabling
 functionality. Our sandbox already disables all exec calls.
 >
 > Not sure it does... All the exeve() calls are disabled by `#if 0`.

 Ah, but that code is for _enabling_ execve.  Unless a syscall is
 specifically enabled, the sandbox code doesn't allow it.

 > The changes file has this weird sentence:
 >
 > {{{
 >     - Added a new NoExec option to . When this option is set to 1,
 > }}}

 Oops. Will fix.

 > Apart from that, lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22976#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online