[tor-bugs] #23307 [Core Tor/Tor]: hs: Don't bruteforce every pending connection when we get a RENDEZVOUS ack

[Tor Bug Tracker & Wiki]

#23307: hs: Don't bruteforce every pending connection when we get a RENDEZVOUS ack
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs, prop224
Actual Points:                |  Parent ID:  #23300
       Points:                |   Reviewer:
      Sponsor:  SponsorR-can  |
------------------------------+--------------------------------
 In the v2 subsystem, we have this:

 {{{
   /* XXXX++ This is a pretty brute-force approach. It'd be better to
    * attach only the connections that are waiting on this circuit, rather
    * than trying to attach them all. See comments bug 743. */
   /* If we already have the introduction circuit built, make sure we send
    * the INTRODUCE cell _now_ */
    connection_ap_attach_pending(1);
 }}}

 And v3 is also doing that (#17242) so we should find another approach to
 this instead of scanning the entire set of pending connections.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23307>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online