[tor-bugs] #23305 [Core Tor/Tor]: hs: Maybe don't use REND_DESC_ID_V2_LEN_BASE32 as the length for a base32 relay digest id

[Tor Bug Tracker & Wiki]

#23305: hs: Maybe don't use REND_DESC_ID_V2_LEN_BASE32 as the length for a base32
relay digest id
------------------------------+------------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs, easy, refactor
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------------
 Function `hs_lookup_last_hid_serv_request()` defines an HSDir identity
 digest in base32 as:

 {{{
   char hsdir_id_base32[REND_DESC_ID_V2_LEN_BASE32 + 1];
 }}}

 Although the length is correct, semantically this is bad to use the base32
 descriptor ID length for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23305>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online