[tor-bugs] #23303 [Core Tor/Tor]: hs: Explain why we reset the directory connection timestamp client side

[Tor Bug Tracker & Wiki]

#23303: hs: Explain why we reset the directory connection timestamp client side
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs, prop224
Actual Points:                |  Parent ID:  #23300
       Points:                |   Reviewer:
      Sponsor:  SponsorR-can  |
------------------------------+--------------------------------
 In the v2 HS subsystem we have this in rendclient.c in
 `rend_client_desc_trynow()`:

 {{{
       /* restart their timeout values, so they get a fair shake at
        * connecting to the hidden service. */
       base_conn->timestamp_created = now;
       base_conn->timestamp_lastread = now;
       base_conn->timestamp_lastwritten = now;

 }}}

 We've taken the same thing into the v3 client in #17242 but we need a
 comment that explains *why* we do that because `get a fair shake` is not
 very helpful :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23303>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online