[tor-bugs] #22836 [Metrics/Metrics website]: Parse CollecTor's index.json and provide our own directory listing
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Aug 21 13:59:35 UTC 2017
#22836: Parse CollecTor's index.json and provide our own directory listing
-------------------------------------+------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics/Metrics website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+------------------------------
Comment (by iwakeh):
Replying to [comment:2 karsten]:
> I implemented this. Please review [https://gitweb.torproject.org/karsten
/metrics-
web.git/commit/?h=task-22836&id=12a42e61db528c30171170e358498d0210bfec41
commit 12a42e61 in my task-22836 branch] and admire
[https://trac.torproject.org/projects/tor/attachment/ticket/22836/task-22836-screenshot.png
this screenshot] for an example of it will look like.
>
> Once this is merged and deployed we can remove all web elements from
CollecTor that have the sole purpose of making its directory listings
prettier.
This gain does not justify implementing the JSON-index-handling a third
time, in addition with slight differences. Even now as we're working
toward using an internal API of metrics-lib and metrics-lib already
supplies convenient [https://gitweb.torproject.org/metrics-
lib.git/tree/src/main/java/org/torproject/descriptor/index/IndexNode.java#n83
methods for retrieving index.json*].
(metrics-lib has a way better coverage in addition.)
The change to the FileNode class only seems to concern the comparison.
This leads to the question of either using this type of comparison also in
metrics-lib (small new ticket) or simply providing a Comparator for the
sorting needed here.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22836#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list