[tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

[Tor Bug Tracker & Wiki]

#23215: set annotation from descriptor during sync-runs
-----------------------------------+-----------------------------
     Reporter:  iwakeh             |      Owner:  metrics-team
         Type:  defect             |     Status:  new
     Priority:  Medium             |  Milestone:  CollecTor 1.3.0
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+-----------------------------
 As noticed in #21759:comment10

   Currently, all synced descriptors receive their annotation from the
 Annotation enum (cf. package o.t.c.conf.Annotation). This happens, because
 only the raw bytes are taken from a given descriptor and written to the
 file system.
   But, actually the annotation(s) should be taken from the
 'getAnnotations' method and be prepended to the raw descriptor bytes,
 shouldn't they?
 The fix for this would also simplify some sync-code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23215>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online