[tor-bugs] #22752 [Core Tor/Tor]: Assertion failure in consensus_cache_entry_handle_get on Windows

[Tor Bug Tracker & Wiki]

#22752: Assertion failure in consensus_cache_entry_handle_get on Windows
--------------------------+------------------------------------
 Reporter:  ahf           |          Owner:
     Type:  defect        |         Status:  needs_information
 Priority:  High          |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.1.3-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor4
--------------------------+------------------------------------

Comment (by nickm):

 Replying to [comment:12 Vort]:
 > > I think this bug might be caused by the fact that (I think!) on
 windows, you can't unlink a file that's in use.
 >
 > Yes, adding of `consensus_cache_entry_unmap` call hides "unlink"
 warnings:
 > attachment:unmap_hack.patch
 > But adds other ones, of course.
 >
 > > But our code tries to unlink these files while they are still mapped.
 >
 > Using of deleted file is a strange thing for me.

 It's pretty normal on Unix-derived systems.  Files are reference-counted,
 and not actually deleted until nothing else is using them.  The "unlink()"
 system call doesn't actually delete a file -- it just removes a name from
 from the filesystem. Only when all links and references are gone is the
 actual data deleted.  That's why it's called "unlink()" instead of
 "delete()".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22752#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online