[tor-bugs] #23107 [Core Tor/Tor]: prop224: Optimize hs_circ_service_get_intro_circ() digest calculation

[Tor Bug Tracker & Wiki]

#23107: prop224: Optimize hs_circ_service_get_intro_circ() digest calculation
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  prop224 prop224-extra tor-hs
     Severity:  Normal   |  optimization
Actual Points:           |  Parent ID:
       Points:  0.2      |   Reviewer:
      Sponsor:           |
  SponsorR-can           |
-------------------------+-------------------------------------------------
 Our prop224 function for getting an intro circ given its intro object re-
 calculates the relay identity fpr all the time:
 {{{
   if (ip->base.is_only_legacy) {
     uint8_t digest[DIGEST_LEN];
     if (BUG(crypto_pk_get_digest(ip->legacy_key, (char *) digest) < 0)) {
       goto end;
     }
     circ = hs_circuitmap_get_intro_circ_v2_service_side(digest);
 }}}

 We could shove that in the `hs_service_intro_point_t` object as well to
 cut some digest calculations.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23107>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online