[tor-bugs] #23081 [Core Tor/Tor]: Tor relay crashes at consensus_diff_queue_diff_work() with assertion in_main_thread() failed

[Tor Bug Tracker & Wiki]

#23081: Tor relay crashes at consensus_diff_queue_diff_work() with assertion
in_main_thread() failed
-------------------------------------------------+-------------------------
 Reporter:  Vort                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.5-alpha
 Severity:  Minor                                |     Resolution:
 Keywords:  tor-relay regression win32 nt-       |  Actual Points:
  service 025-backport 028-backport              |
  029-backport 030-backport                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 It was doing other wrong things.  Here's the changes message I wrote up:

 {{{
 +    - When running as a Windows service, set the ID of the main thread
 +      correctly. Failure to do so made us fail to send log messages
 +      to the controller in 0.2.1.16-rc, slowed down controller
 +      event delivery in 0.2.7.3-rc and later, and crash with an assertion
 +      failure in 0.3.1.1-alpha. Fixes bug 23081; bugfix on 0.2.1.6-alpha.
 +      Patch and diagnosis from "Vort".
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23081#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online