[tor-bugs] #23092 [Core Tor/Tor]: CircuitIdleTimeout man entry should document IDLE_TIMEOUT_WHILE_LEARNING
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Aug 3 05:20:33 UTC 2017
#23092: CircuitIdleTimeout man entry should document IDLE_TIMEOUT_WHILE_LEARNING
--------------------------+------------------------------------
Reporter: teor | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version: Tor: 0.2.2.2-alpha
Severity: Normal | Resolution:
Keywords: doc easy | Actual Points:
Parent ID: | Points: 0.2
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by teor):
Using the minimum is a one-line change. This one:
{{{
diff --git a/src/or/circuituse.c b/src/or/circuituse.c
index d77020f19d..531456b259 100644
--- a/src/or/circuituse.c
+++ b/src/or/circuituse.c
@@ -1402,7 +1402,8 @@ circuit_expire_old_circuits_clientside(void)
last_expired_clientside_circuits = now.tv_sec;
if (! circuit_build_times_disabled(get_options()) &&
- circuit_build_times_needs_circuits(get_circuit_build_times())) {
+ circuit_build_times_needs_circuits(get_circuit_build_times()) &&
+ IDLE_TIMEOUT_WHILE_LEARNING < get_options()->CircuitIdleTimeout) {
/* Circuits should be shorter lived if we need more of them
* for learning a good build timeout */
cutoff.tv_sec -= IDLE_TIMEOUT_WHILE_LEARNING;
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23092#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list