[tor-bugs] #23091 [Core Tor/Tor]: Broken condition in check_expired_networkstatus_callback()

[Tor Bug Tracker & Wiki]

#23091: Broken condition in check_expired_networkstatus_callback()
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Patch LGTM.

 I looked to see what are the consequences of fixing this bug: Now the flag
 `need_to_update_have_min_dir_info` will be set only when we receive new
 dirinfo, instead of every 2 minutes. This means we will check if we have
 enough dirinfo to build a circuit only when needed, and not every 2
 minutes. I think that's what was intended originally, so I think we are
 good here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23091#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online