[tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
--------------------------------+------------------------------------
 Reporter:  teor                |          Owner:  nickm
     Type:  defect              |         Status:  needs_review
 Priority:  Medium              |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor        |        Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal              |     Resolution:
 Keywords:  maybe-030-backport  |  Actual Points:
Parent ID:                      |         Points:  0.5
 Reviewer:                      |        Sponsor:  SponsorV
--------------------------------+------------------------------------
Changes (by nickm):

 * status:  accepted => needs_review
 * sponsor:   => SponsorV


Comment:

 Replying to [ticket:22779 teor]:

 I have a patch here as `bug22779_031`.

 > * fix the comment,

 done

 > * check for NULL state (and do what?)

 In this case, we treat it as a nonfatal assertion. I've audited the code
 that calls this to make sure it can't happen.

 > * make sure that guard selection and entry selection doesn't get out of
 sync. (I think we're ok here, but I don't understand the new guard code
 very well.)

 I think we're okay here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22779#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online