[tor-bugs] #21406 [Core Tor/Tor]: The channel is_client flag is inaccurate

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 28 00:32:54 UTC 2017


#21406: The channel is_client flag is inaccurate
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.4.23
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.5
Parent ID:                |         Points:  0.5
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:9 nickm]:
 > I think the change in connection_or_check_valid_tls_handshake() may be
 wrong: This is about the certificate received in the TLS handshake, not
 the certificate received in the CERTS cell during the v3 Tor handshake.
 But in the v3 handshake, ''nobody'' provides a client certificate during
 TLS negotiation.

 I pushed a fixup to connection-with-client-v2 that reverts the
 connection_or_check_valid_tls_handshake() change.

 > The other changes look okay to me.  I would like to rename
 "channel_mark_client" to "channel_mark_as_client" and "channel_is_client"
 to "channel_comes_from_client" or something, but that's another ticket.

 I opened #22090 in 0.3.2 for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21406#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list