[tor-bugs] #22086 [Core Tor/Tor]: Make NO_METHOD a real legit compression method

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Apr 27 14:03:21 UTC 2017


#22086: Make NO_METHOD a real legit compression method
------------------------------+-----------------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  enhancement   |     Status:  new
     Priority:  Low           |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  cleanup null-object-pattern
Actual Points:  0             |  Parent ID:
       Points:  0             |   Reviewer:
      Sponsor:  Sponsor4      |
------------------------------+-----------------------------------------
 There are a few places in the code that do something like
 {{{
   if (compressing) {
      tor_compress(...)
   } else {
      memcpy(...)
   }
 }}}

 Wouldn't it be great if they could just call tor_compress unconditionally?

 They can, if NO_METHOD is treated as a real compression method!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22086>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list