[tor-bugs] #16861 [Core Tor/Tor]: Pad Tor connections to collapse netflow records

[Tor Bug Tracker & Wiki]

#16861: Pad Tor connections to collapse netflow records
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  028-triage, 028-triaged,             |  Actual Points:
  pre028-patch, 201511-deferred,                 |
  201512-deferred, tor-guard, TorCoreTeam-       |
  postponed-201604, nickm-deferred-20160905,     |
  review-group-9, nickm-deferred-20161005        |
Parent ID:                                       |         Points:  6
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Quite happy with the fixes!

 *HOWEVER*, the branch doesn't compile :).

 {{{
 src/or/channelpadding.c: In function
 ‘channelpadding_get_channel_idle_timeout’:
 src/or/channelpadding.c:567:42: error: passing argument 1 of
 ‘channel_is_client’ discards ‘const’ qualifier from pointer target type
 [-Werror=discarded-qualifiers]
    if (!is_canonical || CHANNEL_IS_CLIENT(chan, options)) {
                                           ^
 src/or/channelpadding.c:69:56: note: in definition of macro
 ‘CHANNEL_IS_CLIENT’
    (!public_server_mode((options)) || channel_is_client(chan) || \
                                                         ^~~~
 In file included from src/or/channelpadding.c:12:0:
 src/or/channel.h:668:5: note: expected ‘channel_t * {aka struct channel_s
 *}’ but argument is of type ‘const channel_t * {aka const struct channel_s
 *}’
  int channel_is_client(channel_t *chan);
      ^~~~~~~~~~~~~~~~~
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16861#comment:79>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online