[tor-bugs] #21646 [Core Tor/Tor]: prop140/compression: Refactor "directory request" code

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 26 21:21:48 UTC 2017


#21646: prop140/compression: Refactor "directory request" code
----------------------------------------+----------------------------------
 Reporter:  nickm                       |          Owner:  nickm
     Type:  task                        |         Status:  needs_revision
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.1.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  TorCoreTeam201703, prop140  |  Actual Points:  1
Parent ID:                              |         Points:  1
 Reviewer:                              |        Sponsor:  Sponsor4
----------------------------------------+----------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Really nice change. I like the explicit interfaces much more than the old
 `directory_initiate_command*()` interface for firing off requests. The
 code is much easier to read now.

 I've added a couple of comments to the code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21646#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list