[tor-bugs] #22060 [Core Tor/Tor]: Remove deprecated options from 0.2.9.2-alpha

[Tor Bug Tracker & Wiki]

#22060: Remove deprecated options from 0.2.9.2-alpha
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  config        |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  new => needs_review
 * keywords:  config, easy => config
 * points:  0.2 => 0.5


Comment:

 Some options are more tricky to remove! The branch I present removes the
 following.

  * `AllowInvalidNodes`
  * `AllowSingleHopCircuits`
  * `AllowSingleHopExits`
  * `ExcludeSingleHopRelays`
  * `FastFirstHopPK`
  * `CloseHSClientCircuitsImmediatelyOnTimeout`
  * `CloseHSServiceRendCircuitsImmediatelyOnTimeout`
  * `WarnUnsafeSocks`
  * `{Control,DNS,Dir,Socks,Trans,NATD,OR}ListenAddress`

 Two are still deprecated at this point. `AllowDotExit` is a bit more
 complex and would benefit from its own ticket once this is merged. The
 second is `ClientDNSRejectInternalAddresses` that is still used for test
 networks (see ticket in description).

 For `AllowSingleHopExits` a very small patch is needed to the dir-
 spec.txt.

 Spec: `ticket22060_01`
 Tor: `ticket22060_031_01`

 Extra points! There was a bug that got exposed with the removal of
 `ORListenAddress`. Within `server_mode()`, we used to look at `ORPort_set
 || ORListenAddress` where `ORPort_set` is set in `parse_ports()`.

 However, `options_validate()` is using `server_mode()` at the start to
 check if we need to look at the uname but then the `ORPort_set` is unset
 at that point because the port parsing is just after. Thus, there is an
 extra commit that fixes that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22060#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online