[tor-bugs] #22042 [Core Tor/Tor]: HSFETCH not followed by HS_DESC_CONTENT event

[Tor Bug Tracker & Wiki]

#22042: HSFETCH not followed by HS_DESC_CONTENT event
-----------------------------------+------------------------------------
 Reporter:  nickler                |          Owner:  dgoulet
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor           |        Version:  Tor: 0.2.9.10
 Severity:  Normal                 |     Resolution:
 Keywords:  tor-hs, control, spec  |  Actual Points:
Parent ID:                         |         Points:  0.2
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:11 nickm]:
 > comments:
 >   * I think the torspec fix should say that the behavior began in
 version 0.3.1.1-alpha, and should say what previous versions did.

 See fixup commit in `ticket22042_01`. (And I think you mean 0.3.1.0-alpha
 here unless you are planning to merge this _after_ first alpha? Let me
 know, I can make the change.)

 >   * Should the functions that can now take id_digest == NULL have their
 documentation updated to say so?

 Indeed!

 Fixup commit in `bug22042_031_01`. I have also added an extra commit to
 fix a comment over `control_event_hs_descriptor_content()` because it was
 just badly missing information.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22042#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online