[tor-bugs] #21662 [Core Tor/Tor]: prop278: Add support for LZMA2 and/or Zstandard

[Tor Bug Tracker & Wiki]

#21662: prop278: Add support for LZMA2 and/or Zstandard
----------------------------------------+----------------------------------
 Reporter:  ahf                         |          Owner:  ahf
     Type:  task                        |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.1.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  TorCoreTeam201703, prop278  |  Actual Points:
Parent ID:                              |         Points:  2
 Reviewer:                              |        Sponsor:  Sponsor4
----------------------------------------+----------------------------------
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 I believe I've been over everything you have commented on in the reviews
 now. We've postponed merging the test functions into a simplified function
 that tests all backends and we have postponed doing coverage "hints" in
 the code.

 I've added a clean-up patch of some of the Zstandard code with regards to
 flushing the internal buffer in a more eager manner.

 Let me know if this looks acceptable for merge and I'll happily do the
 squashing as well (whatever you find easiest!)

 Note that this is build on the comments already made in both
 https://gitlab.com/ahf/tor/merge_requests/1 and
 https://gitlab.com/ahf/tor/merge_requests/2 - Gitlab seems to hide that a
 bit.

 Once this code lands we can close both #21662, #21663 and #21664.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21662#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online