[tor-bugs] #21971 [Core Tor/Tor]: Coverity issues in HS circuitmap unittests

[Tor Bug Tracker & Wiki]

#21971: Coverity issues in HS circuitmap unittests
-------------------------------------+------------------------------------
 Reporter:  asn                      |          Owner:
     Type:  defect                   |         Status:  needs_review
 Priority:  Medium                   |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-hs prop224 coverity  |  Actual Points:
Parent ID:                           |         Points:  0.3
 Reviewer:                           |        Sponsor:  SponsorR-can
-------------------------------------+------------------------------------

Comment (by dgoulet):

 Hmmm, patch lgtm but I see possibly other type check issue like in
 `test_establish_intro_wrong_purpose()` where we have:

 {{{
   ssize_t cell_len = 0;
   [...]
   tt_int_op(cell_len, >, 0);
 }}}

 Seems that Coverity doesn't bark on that one and I doubt it's harmful
 also...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21971#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online