[tor-bugs] #21953 [Core Tor/Tor]: Dealing with Tor hardening on Windows properly

[Tor Bug Tracker & Wiki]

#21953: Dealing with Tor hardening on Windows properly
------------------------------+--------------------------------
     Reporter:  cypherpunks   |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.0.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 While gk is waiting (for something?) in #12426, Tor needs its security
 mitigations to be corrected according to
 https://blogs.microsoft.com/microsoftsecure/2009/08/06/setting-sdl-memory-
 related-requirements-before-your-application-starts/ before the release.
 So, adding
 {{{
   HeapSetInformation(NULL, HeapEnableTerminationOnCorruption, NULL, 0);
 }}}
 after
 https://gitweb.torproject.org/tor.git/tree/src/or/main.c?h=release-0.3.0#n3570
 and changing
 {{{
     if (setdeppolicy) setdeppolicy(1); /* PROCESS_DEP_ENABLE */
 }}}
 with
 {{{
     if (setdeppolicy) setdeppolicy(3); /* PROCESS_DEP_ENABLE |
 PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION */
 }}}
 will do the trick.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21953>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online