[tor-bugs] #21919 [Core Tor/Tor]: hs: Change trunnel prop224 cell's namespace

[Tor Bug Tracker & Wiki]

#21919: hs: Change trunnel prop224 cell's namespace
---------------------------------------+-----------------------------------
 Reporter:  dgoulet                    |          Owner:  dgoulet
     Type:  defect                     |         Status:  new
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.1.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-hs, refactor, prop224  |  Actual Points:
Parent ID:  #21888                     |         Points:  0.2
 Reviewer:                             |        Sponsor:  SponsorR-must
---------------------------------------+-----------------------------------
Description changed by dgoulet:

Old description:

> Currently, the trunnel namespace for hidden service cells (in
> `src/trunnel/hs/`) is prefixed with `hs_cell_*`. We want to change this
> for two reasons.
>
> First, if we could have something in the name indicating that it is
> trunnel, it would make it better for code semantic and separation.
>
> Second, we want to create `hs_cells.[ch]` so we can put in there the cell
> creation/parsing/handling instead of growing `hs_circuit.c` to the "hydra
> size".
>
> So for the renaming, here are some suggestions:
>
> 1. `tr_cell_*`
> 2. `tr_hs_cell_*`
> 3. `trunnel_cell_*`
>
> Considering that an `ESTABLISH_INTRO` or `INTRODUCE1` cell is only for
> hidden service, probably the `hs` in there is superfluous?

New description:

 Currently, the trunnel namespace for hidden service cells (in
 `src/trunnel/hs/`) is prefixed with `hs_cell_*`. We want to change this
 for two reasons.

 First, if we could have something in the name indicating that it is
 trunnel, it would make it better for code semantic and separation.

 Second, we want to create `hs_cells.[ch]` so we can put in there the cell
 creation/parsing/handling instead of growing `hs_circuit.c` to the "hydra
 size".

 So for the renaming, here are some suggestions:

 1. `tr_cell_*`
 2. `tr_hs_cell_*`
 3. `trunnel_cell_*`
 4. `trnl_cell_*`

 Considering that an `ESTABLISH_INTRO` or `INTRODUCE1` cell is only for
 hidden service, probably the `hs` in there is superfluous?

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21919#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online