[tor-bugs] #21710 [Applications/Tor Browser]: Upgrade Go to 1.8.1

[Tor Bug Tracker & Wiki]

#21710: Upgrade Go to 1.8.1
----------------------------------------------+----------------------------
 Reporter:  dcf                               |          Owner:  tbb-team
     Type:  task                              |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-gitian TorBrowserTeam201704R  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by dcf):

 Replying to [comment:5 gk]:
 > Yes, I think we wait for a new tag. I am a bit confused about your
 commit message (just nits):
 >
 > 1) "Remove workarounds for fixed upstream bug" <- it seems you are
 removing just one and not several in your patch?
 > 2) "I wasn't able to remove the cc-for-target workaround for GitHub been
 fixed" <- I have a hard time understanding that one.

 Sorry, there were some errors in the commit message. I'll paste the long
 error output here and shorten the log message.

 ----

 Despite https://github.com/golang/go/issues/15457 supposedly being fixed,
 `make.bash` says:

 {{{
 echo '##### Building packages and commands for darwin/amd64.'
 CC='/home/debian/build/clang/bin/clang -target x86_64-apple-darwin10
 -mlinker-version=136 -B /home/debian/build/cctools/bin -isysroot
 /home/debian/build/MacOSX10.7.sdk -std=gnu99'
 /home/debian/build/go/pkg/tool/linux_amd64/go_bootstrap install -gcflags
 '' -ldflags '' -v std cmd
 }}}

 it ends up running something that discards all the options:

 {{{
 cd /home/debian/build/go/src/plugin
 CGO_LDFLAGS="-g" "-O2" /home/debian/build/go/pkg/tool/linux_amd64/cgo
 -objdir $WORK/plugin/_obj/ -importpath plugin -- -I $WORK/plugin/_obj/ -g
 -O2 plugin_dlopen.go
 /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-
 diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches
 -fno-common -I $WORK/plugin/_obj/ -g -O2 -o
 $WORK/plugin/_obj/_cgo_export.o -c $WORK/plugin/_obj/_cgo_export.c
 /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-
 diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches
 -fno-common -I $WORK/plugin/_obj/ -g -O2 -o
 $WORK/plugin/_obj/plugin_dlopen.cgo2.o -c
 $WORK/plugin/_obj/plugin_dlopen.cgo2.c
 /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-
 diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches
 -fno-common -I $WORK/plugin/_obj/ -g -O2 -o $WORK/plugin/_obj/_cgo_main.o
 -c $WORK/plugin/_obj/_cgo_main.c
 /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-
 diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches
 -fno-common -o $WORK/plugin/_obj/_cgo_.o $WORK/plugin/_obj/_cgo_main.o
 $WORK/plugin/_obj/_cgo_export.o $WORK/plugin/_obj/plugin_dlopen.cgo2.o -g
 -O2
 }}}

 and fails with these errors:

 {{{
 /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.o: In function
 `_cgo_e64586f1776f_Cfunc_pluginLookup':
 /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x2f):
 undefined reference to `dlsym'
 /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x3c):
 undefined reference to `dlerror'
 /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.o: In function
 `_cgo_e64586f1776f_Cfunc_pluginOpen':
 /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x80):
 undefined reference to `dlopen'
 /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x8d):
 undefined reference to `dlerror'
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21710#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online