[tor-bugs] #21712 [Applications/Tor Browser]: Is our patch for #19212 still necessary in ESR52?

[Tor Bug Tracker & Wiki]

#21712: Is our patch for #19212 still necessary in ESR52?
--------------------------------------+------------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201704R     |  Actual Points:
Parent ID:  #20680                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by arthuredelstein):

 * keywords:   => TorBrowserTeam201704R


Comment:

 Replying to [comment:4 gk]:
 > Replying to [comment:3 arthuredelstein]:
 > > So, like Georg, I was able to reproduce the crash using an earlier
 version of Tor Browser. I also could reproduce it reverting the #19212
 patch in the latest TBB/ESR45.
 > >
 > > But now I realize that in our TBB/ESR52 branch, the game shows an
 error message: "Failed to download game data!" This message seems to
 happen, I think, before the crash in the TBB/ESR45 version.
 >
 > I don't think so? comment:5:ticket:19212 seems to indicate the opposite
 if I am reading it right. And comment:7:ticket:19212 seems to indicate
 that those things are not related at all. If either of those is the case
 and we are reaching this message without our rebased fix and without a
 crash then let's get rid of it.

 Yeah, oddly I don't see the "Failed to download game data!" message in
 TBB/ESR45. Not sure why that is. But my subsequent experiment (comment:5)
 is also consistent with them being separate issues.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21712#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online